David Erskine — Scottish advocate, judge and commissioner to parliament